-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Feature: Display OneDrive size on 23H2 #16882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM! Sadly CsWin32 (win32metadata) doesn't provide these WinRT contracts as of now and thus we have to define by ourselves. I'll open a ticket for this in the win32metadata repo soon. |
There seems to be an issue where the free space is higher than the capacity. |
I wasn't able to replicate on my machine, can you send me over a screenshot (and what File Explorer reports if it's available)? |
The issue is visible in your screenshot as well, capacity is shown as 1 TB and the free space is listed as more than 1 TB. |
Looked into it, and it's a separate formatting bug within Files. Files internally process sizes in base two but uses base ten suffixes. |
The more correct suffix is TiB (1 TiB = 1024 GiB). |
How do we want to move forward with this? |
I think that issue should be filed and resolved separately, since it's out of scope for this. That issue affects regular drives as well, not just this new implementation. |
@dongle-the-gadget thank you! |
There are a couple of things to follow up on, but they aren't blocking.
|
Resolved / Related Issues
#10001 (not using the "closes" word as I don't believe this is a complete fix)
Steps used to test these changes
Checked by opening the Properties window of OneDrive Cloud Drives and local drives. Both reports correct sizes.