Skip to content

Feature: Display OneDrive size on 23H2 #16882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

dongle-the-gadget
Copy link
Contributor

@dongle-the-gadget dongle-the-gadget commented Mar 2, 2025

Resolved / Related Issues

#10001 (not using the "closes" word as I don't believe this is a complete fix)

Steps used to test these changes

Checked by opening the Properties window of OneDrive Cloud Drives and local drives. Both reports correct sizes.

@dongle-the-gadget dongle-the-gadget changed the title Report OneDrive size on 23H2. Report OneDrive size on 23H2 Mar 2, 2025
@yaira2 yaira2 changed the title Report OneDrive size on 23H2 Feature: Display OneDrive size on 23H2 Mar 2, 2025
@0x5bfa
Copy link
Member

0x5bfa commented Mar 2, 2025

LGTM!

Sadly CsWin32 (win32metadata) doesn't provide these WinRT contracts as of now and thus we have to define by ourselves. I'll open a ticket for this in the win32metadata repo soon.

@yaira2
Copy link
Member

yaira2 commented Mar 3, 2025

There seems to be an issue where the free space is higher than the capacity.

@dongle-the-gadget
Copy link
Contributor Author

There seems to be an issue where the free space is higher than the capacity.

I wasn't able to replicate on my machine, can you send me over a screenshot (and what File Explorer reports if it's available)?

@yaira2
Copy link
Member

yaira2 commented Mar 3, 2025

The issue is visible in your screenshot as well, capacity is shown as 1 TB and the free space is listed as more than 1 TB.

@dongle-the-gadget
Copy link
Contributor Author

Looked into it, and it's a separate formatting bug within Files. Files internally process sizes in base two but uses base ten suffixes.

@0x5bfa
Copy link
Member

0x5bfa commented Mar 4, 2025

The more correct suffix is TiB (1 TiB = 1024 GiB).

@yaira2
Copy link
Member

yaira2 commented Mar 6, 2025

How do we want to move forward with this?

@dongle-the-gadget
Copy link
Contributor Author

dongle-the-gadget commented Mar 7, 2025

I think that issue should be filed and resolved separately, since it's out of scope for this. That issue affects regular drives as well, not just this new implementation.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 10, 2025
@yaira2 yaira2 merged commit 283345a into files-community:main Mar 10, 2025
6 checks passed
@yaira2
Copy link
Member

yaira2 commented Mar 10, 2025

@dongle-the-gadget thank you!

@yaira2
Copy link
Member

yaira2 commented Mar 10, 2025

There are a couple of things to follow up on, but they aren't blocking.

  • Enable the storage overview in the details pane for OneDrive
  • Investigate the incorrect display for capacity
  • Support for older versions of Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants